From: Jakub Narebski Date: Sun, 02 Apr 2006 13:41:20 GMT Subject: Re: [PATCH] Use _type constants instead of literal constants Message-ID: In-Reply-To: <20060402130051.GA2933@ebar091.ebar.dtu.dk> Peter Eriksen wrote: > From: Peter Eriksen > Date: Sun Apr 2 14:44:09 2006 +0200 > Subject: [PATCH] Use blob_, commit_, tag_, and tree_type throughout. > > This replaces occurences of "blob", "commit", "tag", and "tree", > where they're really used as type specifiers, which we already > have defined global constants for. Shouldn't the name of constant rather be e.g. instead of blob_type be type_blob, and similarly for the rest of type constants? -- Jakub Narebski Warsaw, Poland