git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] builtin/rebase: remove a call to get_oid() on `options.switch_to'

From
Alban Gruin <alban.gruin@gmail.com>
Date
Feb 14, 2020, 20:43 UTC
Message-ID
<df9ede1c-f657-d96f-2d4c-479245f2a2d8@gmail.com>
In-Reply-To
<xmqq1rrr6ww2.fsf@gitster-ct.c.googlers.com>
Hi Junio,
Le 22/01/2020 à 21:47, Junio C Hamano a écrit :
Show 12 quoted lines
> Alban Gruin <alban.gruin@gmail.com> writes:
> 
>> When `options.switch_to' is set, `options.orig_head' is populated right
>> after.  Therefore, there is no need to parse `switch_to' again.
>>
>> Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
>> ---
>>  builtin/rebase.c | 10 +---------
>>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> Sounds good.
> 
Did this patch fell through the cracks?
Alban
Previous: Junio C Hamano
Message 4 of 4 in “builtin/rebase: remove a call to get_oid() on `options.switch_to'”
  1. builtin/rebase: remove a call to get_oid() on `options.switch_to'Alban Gruin, Jan 21, 2020
  2. Johannes SchindelinJan 22, 2020
  3. Junio C HamanoJan 22, 2020
  4. Alban GruinFeb 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.