git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1] builtin/rebase: remove a call to get_oid() on `options.switch_to'

From
Alban Gruin <alban.gruin@gmail.com>
Date
Jan 21, 2020, 19:32 UTC
Message-ID
<20200121193226.24297-1-alban.gruin@gmail.com>

When `options.switch_to' is set, `options.orig_head' is populated right after. Therefore, there is no need to parse `switch_to' again.

Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
---
 builtin/rebase.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 6154ad8fa5..16d2ec7ebc 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -2056,19 +2056,11 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
 		if (!(options.flags & REBASE_FORCE)) {
 			/* Lazily switch to the target branch if needed... */
 			if (options.switch_to) {
-				struct object_id oid;
-
-				if (get_oid(options.switch_to, &oid) < 0) {
-					ret = !!error(_("could not parse '%s'"),
-						      options.switch_to);
-					goto cleanup;
-				}
-
 				strbuf_reset(&buf);
 				strbuf_addf(&buf, "%s: checkout %s",
 					    getenv(GIT_REFLOG_ACTION_ENVIRONMENT),
 					    options.switch_to);
-				if (reset_head(&oid, "checkout",
+				if (reset_head(&options.orig_head, "checkout",
 					       options.head_name,
 					       RESET_HEAD_RUN_POST_CHECKOUT_HOOK,
 					       NULL, buf.buf) < 0) {
-- 
2.24.1
Next: Johannes Schindelin
Message 1 of 4 in “builtin/rebase: remove a call to get_oid() on `options.switch_to'”
  1. builtin/rebase: remove a call to get_oid() on `options.switch_to'Alban Gruin, Jan 21, 2020
  2. Johannes SchindelinJan 22, 2020
  3. Junio C HamanoJan 22, 2020
  4. Alban GruinFeb 14, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.