Re: [PATCH v1 0/3] fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word")

From: Tim Schumacher <timschumi@gmx.de>
Date: Jan 12, 2023, 00:45 UTC
Message-ID: <df736b4c-3773-9f14-f66b-1325688634ab@gmx.de>
In-Reply-To: <20230111233242.16870-1-rybak.a.v@gmail.com>

On 12.01.23 00:32, Andrei Rybak wrote:

Show 11 quoted lines

> [...]
>
> Here's a patch series that fixes some of the commented out test code.
>
> I skipped changing the following:
>
> 1. a minute-long test_expect_failure is commented out in t0014-alias.sh .
>     Technically, this could be uncommented and marked with `EXPENSIVE`
>     prerequisite, but it doesn't seem worth it for a `test_expect_failure`.
>     [ cc Tim Schumacher, who added this test in fef5f7fc43 (t0014: introduce an
>     alias testing suite, 2018-09-16) ]

The reason why this particular test is commented out (and why it mentions a run time of one minute) is because support for detecting external alias loops isn't yet implemented. This means that running that test would spin the test runner until the test times out due to an intentional infinite loop.

As soon as that is implemented properly, git would ideally detect the loop after a few iterations at latest, so the test wouldn't require to be marked as 'EXPENSIVE' in the first place.

For the context of your patches, skipping adjusting this test is most likely fine, as it references currently unimplemented behavior and it presumably would require more adjustments anyways before finally being enabled.

>
> [...]
>

Tim