git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v1 2/3] t6422: drop commented out code

From
Andrei Rybak <rybak.a.v@gmail.com>
Date
Jan 11, 2023, 23:32 UTC
Message-ID
<20230111233242.16870-3-rybak.a.v@gmail.com>
In-Reply-To
<20230111233242.16870-1-rybak.a.v@gmail.com>

In commit [1] tests in t6422-merge-rename-corner-cases.sh were refactored to not run setup steps separately. This included replacing all tests like

	test_expect_success "setup ..." '
		<code of setup>
	'
with corresponding Shell functions
	test_setup_... () {
		<code of setup>
	}

During this replacement first and last lines of one of such tests got left commented out in code. Drop these lines to avoid confusion.

[1] da1e295e00 (t604[236]: do not run setup in separate tests, 2019-10-22)
Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
---
 t/t6422-merge-rename-corner-cases.sh | 2 --
 1 file changed, 2 deletions(-)
diff --git a/t/t6422-merge-rename-corner-cases.sh b/t/t6422-merge-rename-corner-cases.sh
index 346253c7c8..076b6a74d5 100755
--- a/t/t6422-merge-rename-corner-cases.sh
+++ b/t/t6422-merge-rename-corner-cases.sh
@@ -1159,7 +1159,6 @@ test_conflicts_with_adds_and_renames() {
 	#   4) There should not be any three~* files in the working
 	#      tree
 	test_setup_collision_conflict () {
-	#test_expect_success "setup simple $sideL/$sideR conflict" '
 		git init simple_${sideL}_${sideR} &&
 		(
 			cd simple_${sideL}_${sideR} &&
@@ -1236,7 +1235,6 @@ test_conflicts_with_adds_and_renames() {
 			fi &&
 			test_tick && git commit -m R
 		)
-	#'
 	}
 
 	test_expect_success "check simple $sideL/$sideR conflict" '
-- 
2.39.0
Previous: Andrei RybakNext: Andrei Rybak
Message 3 of 8 in “fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word")”
  1. 0/3 fixes for commented out code in tests (was "Re: [PATCH] *: fix typos which duplicate a word")Andrei Rybak, Jan 11, 2023
  2. 1/3 t6003: uncomment test '--max-age=c3, --topo-order'Andrei Rybak, Jan 11, 2023
  3. 2/3 t6422: drop commented out codeAndrei Rybak, Jan 11, 2023
  4. 3/3 t7527: use test_when_finished in 'case insensitive+preserving'Andrei Rybak, Jan 11, 2023
  5. Eric SunshineJan 14, 2023
  6. Tim SchumacherJan 12, 2023
  7. Elijah NewrenJan 12, 2023
  8. Elijah NewrenJan 13, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.