git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] 2.44.0 t7704.9 Fails on NonStop ia64

From
Pphillip.wood123@gmail.com <phillip.wood123@gmail.com>
Date
Feb 27, 2024, 10:43 UTC
Message-ID
<ded76144-91e4-4b24-bcb9-8eec5f589c4a@gmail.com>
In-Reply-To
<Zd2hMmIzHKQ7JE45@tanuki>
Hi Patrick
On 27/02/2024 08:45, Patrick Steinhardt wrote:
Show 19 quoted lines
> On Mon, Feb 26, 2024 at 03:32:14PM +0000, Phillip Wood wrote:
>>>>> reftable/writer.c:              int n = w->write(w->write_arg, zeroed,
>>>>> w->pending_padding);
>>>>> reftable/writer.c:      n = w->write(w->write_arg, data, len);
>>
>> Neither of these appear to check for short writes and reftable_fd_write() is
>> a thin wrapper around write(). Maybe reftable_fd_write() should be using
>> write_in_full()?
> 
> It already does starting with 85a8c899ce (reftable: handle interrupted
> writes, 2023-12-11):
> 
> ```
> static ssize_t reftable_fd_write(void *arg, const void *data, size_t sz)
> {
> 	int *fdp = (int *)arg;
> 	return write_in_full(*fdp, data, sz);
> }
> ```

Oh, the branch I had checkout out was older than I realized, sorry for the confusion.

Best Wishes
Phillip
Previous: Patrick SteinhardtNext: rsbecker@nexbridge.com
Message 12 of 15 in “[BUG] 2.44.0 t7704.9 Fails on NonStop ia64”
  1. rsbecker@nexbridge.comFeb 25, 2024
  2. rsbecker@nexbridge.comFeb 25, 2024
  3. Torsten BögershausenFeb 25, 2024
  4. rsbecker@nexbridge.comFeb 25, 2024
  5. Phillip WoodFeb 26, 2024
  6. rsbecker@nexbridge.comFeb 26, 2024
  7. Phillip WoodFeb 26, 2024
  8. rsbecker@nexbridge.comFeb 26, 2024
  9. rsbecker@nexbridge.comFeb 26, 2024
  10. phillip.wood123@gmail.comFeb 26, 2024
  11. Patrick SteinhardtFeb 27, 2024
  12. phillip.wood123@gmail.comFeb 27, 2024
  13. rsbecker@nexbridge.comFeb 27, 2024
  14. Patrick SteinhardtFeb 27, 2024
  15. rsbecker@nexbridge.comFeb 27, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.