From: phillip.wood123@gmail.com
Date: Tue, 27 Feb 2024 10:43:38 GMT
Subject: Re: [BUG] 2.44.0 t7704.9 Fails on NonStop ia64
Message-ID: <ded76144-91e4-4b24-bcb9-8eec5f589c4a@gmail.com>
In-Reply-To: <Zd2hMmIzHKQ7JE45@tanuki>

Hi Patrick

On 27/02/2024 08:45, Patrick Steinhardt wrote:
> On Mon, Feb 26, 2024 at 03:32:14PM +0000, Phillip Wood wrote:
>>>>> reftable/writer.c:              int n = w->write(w->write_arg, zeroed,
>>>>> w->pending_padding);
>>>>> reftable/writer.c:      n = w->write(w->write_arg, data, len);
>>
>> Neither of these appear to check for short writes and reftable_fd_write() is
>> a thin wrapper around write(). Maybe reftable_fd_write() should be using
>> write_in_full()?
> 
> It already does starting with 85a8c899ce (reftable: handle interrupted
> writes, 2023-12-11):
> 
> ```
> static ssize_t reftable_fd_write(void *arg, const void *data, size_t sz)
> {
> 	int *fdp = (int *)arg;
> 	return write_in_full(*fdp, data, sz);
> }
> ```

Oh, the branch I had checkout out was older than I realized, sorry for 
the confusion.

Best Wishes

Phillip