git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Breakage] Git v2.21.0-rc0 - t5318 (NonStop)

From
Johannes Sixt <j6t@kdbg.org>
Date
Feb 10, 2019, 09:40 UTC
Message-ID
<de25ab29-e4dc-aee2-7396-657c71a550dd@kdbg.org>
In-Reply-To
<20190209232928.GA7135@sigill.intra.peff.net>
Am 10.02.19 um 00:29 schrieb Jeff King:
Show 13 quoted lines
> On Sat, Feb 09, 2019 at 09:39:43AM +0100, Johannes Sixt wrote:
>>  	dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=0 &&
>> -	dd if=/dev/zero of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=$(($orig_size - $zero_pos)) &&
>> +	printf "%0*d" $(($orig_size - $zero_pos)) 0 | tr 0 '\0' |
>> +		dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" &&
> 
> Using stdin instead of the tmpfile is nice, and shouldn't have any
> problems. I do think your printf suggestion looks nice, but I wondered
> if it might run into portability issues (not because of anything in
> particular, but I often find that the more clever a shell solution, the
> more likely we run into obscure problems).
> 
> But if it works everywhere, that's fine by me.

Unfortunately, it does not work as intended: the printf solution cannot print nothing, but that should be the case in all but one of the tests.

-- Hannes
Previous: Jeff KingNext: Randall S. Becker
Message 24 of 25 in “[Breakage] Git v2.21.0-rc0 - t5318 (NonStop)”
  1. Randall S. BeckerFeb 8, 2019
  2. Jeff KingFeb 8, 2019
  3. Randall S. BeckerFeb 8, 2019
  4. Jeff KingFeb 8, 2019
  5. Johannes SixtFeb 8, 2019
  6. Junio C HamanoFeb 8, 2019
  7. Randall S. BeckerFeb 8, 2019
  8. Jeff KingFeb 8, 2019
  9. Randall S. BeckerFeb 8, 2019
  10. Jeff KingFeb 8, 2019
  11. Randall S. BeckerFeb 8, 2019
  12. Jeff KingFeb 8, 2019
  13. Randall S. BeckerFeb 8, 2019
  14. brian m. carlsonFeb 8, 2019
  15. Randall S. BeckerFeb 8, 2019
  16. brian m. carlsonFeb 8, 2019
  17. Randall S. BeckerFeb 8, 2019
  18. Jeff KingFeb 8, 2019
  19. Randall S. BeckerFeb 8, 2019
  20. Jeff KingFeb 9, 2019
  21. Johannes SixtFeb 9, 2019
  22. Randall S. BeckerFeb 9, 2019
  23. Jeff KingFeb 9, 2019
  24. Johannes SixtFeb 10, 2019
  25. Randall S. BeckerFeb 9, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.