Re: [Breakage] Git v2.21.0-rc0 - t5318 (NonStop)

From: Jeff King <peff@peff.net>
Date: Feb 8, 2019, 21:00 UTC
Message-ID: <20190208210041.GA788@sigill.intra.peff.net>
In-Reply-To: <003a01d4bfee$349245b0$9db6d110$@nexbridge.com>

[-cc kernel and packagers; this is really just git development at this point]

On Fri, Feb 08, 2019 at 03:38:05PM -0500, Randall S. Becker wrote:

Show 6 quoted lines

> > Exactly (if we even care about them being NULs; otherwise, we can omit the
> > "tr" invocation).
> 
> I'm a bit perplexed about this... Obviously added some debugging info,
> but why we're getting No REQUEST_METHOD is perplexing. Is this a lack
> of an apache2 instance?

No, this shouldn't be using apache at all. But...

Show 22 quoted lines

> expecting success:
>         NOT_FIT_IN_SSIZE=$(ssize_b100dots) &&
>         env \
>                 CONTENT_TYPE=application/x-git-upload-pack-request \
>                 QUERY_STRING=/repo.git/git-upload-pack \
>                 PATH_TRANSLATED="$PWD"/.git/git-upload-pack \
>                 GIT_HTTP_EXPORT_ALL=TRUE \
>                 REQUEST_METHOD=POST \
>                 CONTENT_LENGTH="$NOT_FIT_IN_SSIZE" \
>                 yes | tr "y" "\\0" | git http-backend 2>err &&
>         echo "Err is" &&
>         cat err &&
>         grep "fatal:.*CONTENT_LENGTH" err
> 
> Status: 500 Internal Server Error
> Expires: Fri, 01 Jan 1980 00:00:00 GMT
> Pragma: no-cache
> Cache-Control: no-cache, max-age=0, must-revalidate
> 
> Err is
> fatal: No REQUEST_METHOD from server
> not ok 15 - CONTENT_LENGTH overflow ssite_t

The problem is that you're setting the environment now for "yes". You'd need:

  yes | tr "y" "\\0" | env \
    CONTENT_TYPE=... \
    REQUEST_METHOD=POST \
    ...etc...
    git http-backend

-Peff