git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 3/3] commit-slab: missing definitions and forward declarations (hdr-check)

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Oct 27, 2018, 01:45 UTC
Message-ID
<de120e07-0b26-295e-3128-e8b3891577e2@ramsayjones.plus.com>
In-Reply-To
<CAPUEspiFDX8280qezkQ0WvJ5-9cp2eG3p+zX4F6HZNgLBACoHw@mail.gmail.com>
On 26/10/2018 04:15, Carlo Arenas wrote:
Show 13 quoted lines
> On Thu, Oct 25, 2018 at 2:09 PM Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>> Yes, this will 'fix' the 'commit-reach.h' header (not surprising),
>> but I prefer my patch. ;-)
> 
> I apologize, I joined the list recently and so might had missed a
> reroll; the merged series in pu doesn't seem to include it and the
> error was around the code I changed, so wanted to make sure it would
> be addressed sooner rather than later.
> 
> eitherway, I agree with you my patch (or something better) would fit
> better in your topic branch than on mine and while I haven't seen your
> patch I am sure is most likely better.
Hmm, I don't know about that!

Since the original series has progressed, any additions will now result in a new set of patches, rather than a re-roll.

The original 'commit-reach.h' patch was not applied as part of the last series, since the commit message was felt to be lacking (well, it was actually non-existent!). ;-)

I have been making some additional changes to the 'hdr-check' target in the Makefile, but I haven't quite finished. I will send the other (non-Makefile) changes soon. [These patches will make the 'master' and 'next' branches 'hdr-check' clean for me].

ATB, Ramsay Jones

Previous: Carlo Arenas
Message 9 of 9 in “delta-islands: avoid unused function messages”
  1. 0/3 delta-islands: avoid unused function messagesCarlo Marcelo Arenas Belón, Oct 25, 2018
  2. 1/3 commit-slab: move MAYBE_UNUSED into git-compat-utilCarlo Marcelo Arenas Belón, Oct 25, 2018
  3. 2/3 khash: silence -Wunused-function in delta-islands from khashCarlo Marcelo Arenas Belón, Oct 25, 2018
  4. SZEDER GáborOct 25, 2018
  5. 3/3 commit-slab: missing definitions and forward declarations (hdr-check)Carlo Marcelo Arenas Belón, Oct 25, 2018
  6. Ramsay JonesOct 25, 2018
  7. Ramsay JonesOct 25, 2018
  8. Carlo ArenasOct 26, 2018
  9. Ramsay JonesOct 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.