git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/3] commit-slab: missing definitions and forward declarations (hdr-check)

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Oct 25, 2018, 11:04 UTC
Message-ID
<20181025110427.13655-4-carenas@gmail.com>
In-Reply-To
<20181025110427.13655-1-carenas@gmail.com>

struct commmit needs to be defined before commit-slab can generate working code, object_id should be at least known through a forward declaration

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 commit-slab-impl.h | 2 ++
 commit-slab.h      | 2 ++
 2 files changed, 4 insertions(+)
diff --git a/commit-slab-impl.h b/commit-slab-impl.h
index e352c2f8c1..db7cf3f19b 100644
--- a/commit-slab-impl.h
+++ b/commit-slab-impl.h
@@ -1,6 +1,8 @@
 #ifndef COMMIT_SLAB_IMPL_H
 #define COMMIT_SLAB_IMPL_H
 
+#include "commit.h"
+
 #define implement_static_commit_slab(slabname, elemtype) \
 	implement_commit_slab(slabname, elemtype, MAYBE_UNUSED static)
 
diff --git a/commit-slab.h b/commit-slab.h
index 69bf0c807c..722252de61 100644
--- a/commit-slab.h
+++ b/commit-slab.h
@@ -1,6 +1,8 @@
 #ifndef COMMIT_SLAB_H
 #define COMMIT_SLAB_H
 
+struct object_id;
+
 #include "commit-slab-decl.h"
 #include "commit-slab-impl.h"
 
-- 
2.19.1
Previous: SZEDER GáborNext: Ramsay Jones
Message 5 of 9 in “delta-islands: avoid unused function messages”
  1. 0/3 delta-islands: avoid unused function messagesCarlo Marcelo Arenas Belón, Oct 25, 2018
  2. 1/3 commit-slab: move MAYBE_UNUSED into git-compat-utilCarlo Marcelo Arenas Belón, Oct 25, 2018
  3. 2/3 khash: silence -Wunused-function in delta-islands from khashCarlo Marcelo Arenas Belón, Oct 25, 2018
  4. SZEDER GáborOct 25, 2018
  5. 3/3 commit-slab: missing definitions and forward declarations (hdr-check)Carlo Marcelo Arenas Belón, Oct 25, 2018
  6. Ramsay JonesOct 25, 2018
  7. Ramsay JonesOct 25, 2018
  8. Carlo ArenasOct 26, 2018
  9. Ramsay JonesOct 27, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.