git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 1/4] config: minor addition of whitespace

From
DSDragan Simic <dsimic@manjaro.org>
Date
Mar 21, 2024, 04:17 UTC
Message-ID
<dda81fedd9f38cb57658f1343f803a339c9116e3.1710994548.git.dsimic@manjaro.org>
In-Reply-To
<cover.1710994548.git.dsimic@manjaro.org>

In general, binary operators should be enclosed in a pair of leading and trailing space (SP) characters. Thus, clean up one spotted expression that for some reason had a "bunched up" operator.

Signed-off-by: Dragan Simic <dsimic@manjaro.org>
---
Notes:
    Changes in v4:
        - Junio responded with "will queue" in v3, [1] but this patch hasn't
          reached the "next" branch yet, so resending it as a reminder
        - No changes were introduced
    
    Changes in v3:
        - Patch description was expanded a tiny bit, to make it more accurate
        - No changes to the source code were introduced
    
    Changes in v2:
        - No changes were introduced
    
    [1] https://lore.kernel.org/git/xmqq5xxhl8gs.fsf@gitster.g/
 config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config.c b/config.c
index 3cfeb3d8bd99..a86a20cdf5cb 100644
--- a/config.c
+++ b/config.c
@@ -869,7 +869,7 @@ static char *parse_value(struct config_source *cs)
 			continue;
 		}
 		if (c == '"') {
-			quote = 1-quote;
+			quote = 1 - quote;
 			continue;
 		}
 		strbuf_addch(&cs->value, c);
Previous: Dragan SimicNext: Dragan Simic
Message 2 of 14 in “Fix a bug in configuration parsing, and improve tests and documentation”
  1. 0/4 Fix a bug in configuration parsing, and improve tests and documentationDragan Simic, Mar 21, 2024
  2. 1/4 config: minor addition of whitespaceDragan Simic, Mar 21, 2024
  3. 2/4 config: really keep value-internal whitespace verbatimDragan Simic, Mar 21, 2024
  4. 3/4 t1300: add more tests for whitespace and inline commentsDragan Simic, Mar 21, 2024
  5. Eric SunshineMar 21, 2024
  6. Dragan SimicMar 21, 2024
  7. 4/4 config.txt: describe handling of whitespace furtherDragan Simic, Mar 21, 2024
  8. Eric SunshineMar 21, 2024
  9. Dragan SimicMar 21, 2024
  10. Eric SunshineMar 21, 2024
  11. Dragan SimicMar 21, 2024
  12. Junio C HamanoMar 21, 2024
  13. Eric SunshineMar 21, 2024
  14. Dragan SimicMar 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.