git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/4] Fix a bug in configuration parsing, and improve tests and documentation

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 21, 2024, 04:50 UTC
Message-ID
<CAPig+cRCCqRHYOpMxdL4MWaSF5S0Qb7fcJ5HqkT0j_MU1dRvfQ@mail.gmail.com>
In-Reply-To
<cover.1710994548.git.dsimic@manjaro.org>
On Thu, Mar 21, 2024 at 12:17 AM Dragan Simic <dsimic@manjaro.org> wrote:
> In v2, this series had five patches in total, out of which the third patch
> (i.e. patch 3/5) was dropped in v3. [4]  Other changes in each version are
> described in each patch.

In addition to a written description of the changes since the previous version, reviewers also greatly appreciate seeing a range-diff which you can generate automatically in the cover-letter via:

   git format-patch --cover-letter --range-diff=<...> ...
or less frequently, an interdiff via:
    git format-patch --cover-letter --interdiff=<...> ...

Both options (--range-diff & --interdiff) also work for single-patch series which lack a cover-letter.

Previous: Junio C HamanoNext: Dragan Simic
Message 13 of 14 in “Fix a bug in configuration parsing, and improve tests and documentation”
  1. 0/4 Fix a bug in configuration parsing, and improve tests and documentationDragan Simic, Mar 21, 2024
  2. 1/4 config: minor addition of whitespaceDragan Simic, Mar 21, 2024
  3. 2/4 config: really keep value-internal whitespace verbatimDragan Simic, Mar 21, 2024
  4. 3/4 t1300: add more tests for whitespace and inline commentsDragan Simic, Mar 21, 2024
  5. Eric SunshineMar 21, 2024
  6. Dragan SimicMar 21, 2024
  7. 4/4 config.txt: describe handling of whitespace furtherDragan Simic, Mar 21, 2024
  8. Eric SunshineMar 21, 2024
  9. Dragan SimicMar 21, 2024
  10. Eric SunshineMar 21, 2024
  11. Dragan SimicMar 21, 2024
  12. Junio C HamanoMar 21, 2024
  13. Eric SunshineMar 21, 2024
  14. Dragan SimicMar 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.