git/list[1] front-page[2] threads[3] people[4] search[5] about
 

bug report: "git pack-redundant --all" crash in minimize()

From
DKDaniel C. Klauer <daniel.c.klauer@web.de>
Date
Dec 15, 2020, 17:34 UTC
Message-ID
<dc410ef1-fc05-162e-ed4e-c843e0bc285d@web.de>
Hello,

I'm getting the following crash from "git pack-redundant --all" (output from valgrind):

==14070== Invalid read of size 8 ==14070== at 0x18F165: minimize (pack-redundant.c:399) ==14070== by 0x18F165: cmd_pack_redundant (pack-redundant.c:622) ==14070== by 0x1242D3: run_builtin (git.c:444) ==14070== by 0x1242D3: handle_builtin (git.c:674) ==14070== by 0x125393: run_argv (git.c:741) ==14070== by 0x125393: cmd_main (git.c:872) ==14070== by 0x123E7D: main (common-main.c:52) ==14070== Address 0x10 is not stack'd, malloc'd or (recently) free'd

Commands to reproduce:

mkdir new cd new git init touch foo.txt git add foo.txt git commit -m "first commit" git gc git pack-redundant --all

The same happens with Ubuntu's git 2.25.1 as well as manually compiled git 2.30.0.rc0 from current master.

The reason this showed up is that Yocto's build tool, bitbake, sometimes invokes this git command on some of the repositories it downloaded. This issue was apparently also reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1803506

Kind Regards, Daniel

Next: Jeff King
Message 1 of 11 in “bug report: "git pack-redundant --all" crash in minimize()”
  1. Daniel C. KlauerDec 15, 2020
  2. Jeff KingDec 15, 2020
  3. Junio C HamanoDec 15, 2020
  4. Jiang XinDec 16, 2020
  5. pack-redundant: fix crash when one packfile in repoJiang Xin, Dec 16, 2020
  6. Junio C HamanoDec 16, 2020
  7. pack-redundant: fix crash when one packfile in repoJiang Xin, Dec 17, 2020
  8. Junio C HamanoDec 17, 2020
  9. Jeff KingDec 16, 2020
  10. Daniel KlauerDec 16, 2020
  11. Jeff KingDec 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.