Re: bug report: "git pack-redundant --all" crash in minimize()

From: Daniel Klauer <daniel.c.klauer@web.de>
Date: Dec 16, 2020, 13:22 UTC
Message-ID: <a46660c3-630c-5573-9ef4-75d273d37767@web.de>
In-Reply-To: <X9j+nuzjiYyw/vQx@coredump.intra.peff.net>

On 15.12.20 19:21, Jeff King wrote:

Show 9 quoted lines

> On Tue, Dec 15, 2020 at 06:34:53PM +0100, Daniel C. Klauer wrote:
>> The reason this showed up is that Yocto's build tool, bitbake, sometimes
>> invokes this git command on some of the repositories it downloaded. This
>> issue was apparently also reported here:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1803506
>
> We had a discussion not too long ago[1] about whether we should
> deprecate and remove pack-redundant, as it's not generally useful. I'm
> curious if you have any more context on why it's used in that tool.

Background: bitbake downloads git repositories during a build process
and supports caching them locally (in form of bare repos in some
user-defined directory). This prevents having to re-download them during
the next build, and also it is a convenient mirroring/backup system in
case the original URLs stop working.

As far as I can tell (since I'm not a bitbake developer) the git pack-redundant invocation is one of multiple calls meant to improve storage (probably minimize disk usage) of the locally cached git repos. For reference, please take a look at the other git commands it's invoking [1], and at the commit messages of the commits that added these invocations [2] [3] [4].

If doing it that way seems wrong, I'll report the issue to bitbake upstream too. Maybe there is a better way to do whatever bitbake wants to do here?

Thanks!

[1] http://git.openembedded.org/bitbake/tree/lib/bb/fetch2/git.py?h=1.48.1#n364 [2] http://git.openembedded.org/bitbake/commit?id=d5d958744fff66cf5286022d78cbec1839fca2e2 [3] http://git.openembedded.org/bitbake/commit?id=f8126aaf774186a6eaf0bd4067b89c074594886c [4] http://git.openembedded.org/bitbake/commit?id=7d55491f88ff90a4c16ad87b1483d55b1824acfc