Re: [RFC] Git config file reader in Perl (WIP)

From: Nikolai Weibull <now@bitwi.se>
Date: Jan 15, 2007, 16:22 UTC
Message-ID: <dbfc82860701150822o47e0e1ecoe22ee81c979dc1ab@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0701151639490.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On 1/15/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> On Mon, 15 Jan 2007, Nikolai Weibull wrote:

> > On 1/15/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> > > On Mon, 15 Jan 2007, Eric Wong wrote:

> > > > > Would you write "git repo-config --perl", then? ;-)

> > > > The below patch should be a start (only tested on my fairly standard
> > > > .git/config).  A --python option should be easy, too :)

> > > A bit shorter (and gets the booleans right, plus being even easier
> > > towards --python extension):

> > If we're going down this slippery slope, why not just give up and add
> > a --xml switch instead?

> AFAIR this switch was meant to _enhance_ performance.

As far as I can tell, comparing fork() vs. reading a dump with eval vs. XML isn't meaningful - parsing a 20-line XML file can hardly be much more (if it even is more) expensive than evaling a file of the same length.

> > That said, parsing the config file as-is can't be so difficult that we
> > need to export it to separate files with a different syntax, now can it?

> The point is having one parser to rule them all, and avoid having
> different parsers, all with their own set of shortcomings.

So then you must agree that having one export format makes a lot of sense, for the same reasons. Not that I think that an export format makes sense in the first place.

  nikolai