Re: [PATCH] config_set_multivar(): disallow newlines in keys

From: Alex Riesen <raa.lkml@gmail.com>
Date: Jan 23, 2007, 12:47 UTC
Message-ID: <81b0412b0701230447sb3cb3e6y125be4d4fa8952f2@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.63.0701231225450.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On 1/23/07, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 13 quoted lines

> > > > We probably don't need it libified completely. Just reading and writing of
> > > > the object database and tags/references and very simple revision walking
> > > > will be a very good start [...]
> > >
> > > ... and even these use xmalloc(), which die()s on out-of-memory. Note that
> > > it would be a really horrible work to libify that, since you basically
> > > have to insert gazillions of free() calls at the right point, which we
> > > don't have to, since exit() cleans up after us anyway.
> >
> > Didn't say it'd be simple. Just not impossible.
>
> I thought that was what you meant by "very simple revision walking".
>

that'd be "just a part of revision walking". Dunno what part yet, because I still have to come up with convincing example of where only a libgit could be used: just committers and history browsers should not have any problems just using plumbing (no, stupid microsoft's createprocess is not a reason enough).