Re: What's cooking in git.git (Dec 2017, #03; Wed, 13)

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Dec 16, 2017, 06:06 UTC
Message-ID: <dbed9ef3-0bf6-01e2-13d2-4c92a243c321@gmail.com>
In-Reply-To: <xmqq1sjxt3tz.fsf@gitster.mtv.corp.google.com>

On Friday 15 December 2017 02:38 AM, Junio C Hamano wrote:

Show 9 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> I think you only sent 3/3 in newer rounds, which made it not to
>> apply to my tree.  If you meant to drop changes in 1/3 and 2/3,
>> perhaps because they were needless churn, then 3/3 needs to be
>> updated not to depend on the changes these two made.
> 
> Here is what I reconstructed to suit my taste better ;-)
>

Looks good to me except that your v4 3/3 seems to be spawning a subshell is an oversight, I guess? Also, I guess it would be better if there was comment in the code saying 'branch_nam' might hold a commit/branch name. No worries I'll send a v5 to that thread based on your v4.

Thanks, Kaartic