From: Kaartic Sivaraam Date: Sat, 16 Dec 2017 06:06:30 GMT Subject: Re: What's cooking in git.git (Dec 2017, #03; Wed, 13) Message-ID: In-Reply-To: On Friday 15 December 2017 02:38 AM, Junio C Hamano wrote: > Junio C Hamano writes: > >> I think you only sent 3/3 in newer rounds, which made it not to >> apply to my tree. If you meant to drop changes in 1/3 and 2/3, >> perhaps because they were needless churn, then 3/3 needs to be >> updated not to depend on the changes these two made. > > Here is what I reconstructed to suit my taste better ;-) > Looks good to me except that your v4 3/3 seems to be spawning a subshell is an oversight, I guess? Also, I guess it would be better if there was comment in the code saying 'branch_nam' might hold a commit/branch name. No worries I'll send a v5 to that thread based on your v4. Thanks, Kaartic