Re: Can dependency on /bin/sh be removed?

From: Paul Smith <psmith@gnu.org>
Date: Jul 16, 2024, 21:40 UTC
Message-ID: <d98f82b8b6434c47fc2d9a4ecc870fef336a9e5a.camel@gnu.org>
In-Reply-To: <87jzhlf2i4.fsf@igel.home>

On Tue, 2024-07-16 at 23:30 +0200, Andreas Schwab wrote:

Show 10 quoted lines

> On Jul 16 2024, Jeff King wrote:
> 
> > Again, it's possible that we could detect that no shell
> > metacharacters are in play and do the word-splitting ourselves. But
> > at that point I think it should go into run-command's
> > prepare_shell_cmd().
> 
> This is what GNU make does (see construct_command_argv_internal), for
> performance reason.  But run_command is probably not performance
> critical.

Also I would definitely not recommend anyone look at this part of the GNU Make code for inspiration. It's an unholy mess.

The concept is very good though.