Re: Can dependency on /bin/sh be removed?
- From
Jeff King <peff@peff.net>
- Date
- Jul 17, 2024, 05:53 UTC
- Message-ID
- <20240717055335.GC547635@coredump.intra.peff.net>
- In-Reply-To
- <87jzhlf2i4.fsf@igel.home>
On Tue, Jul 16, 2024 at 11:30:59PM +0200, Andreas Schwab wrote:
Show 9 quoted lines
> On Jul 16 2024, Jeff King wrote: > > > Again, it's possible that we could detect that no shell metacharacters > > are in play and do the word-splitting ourselves. But at that point I > > think it should go into run-command's prepare_shell_cmd(). > > This is what GNU make does (see construct_command_argv_internal), for > performance reason. But run_command is probably not performance > critical.
Thanks, that's interesting to hear. I agree that run_command is not usually performance critical. Generally if we find ourselves spawning a lot of processes, the right solution is to accomplish the same thing with fewer processes (or even in-process), not micro-optimize out the intermediate shell.
-Peff