Re: [PATCH 3/4] difftool: use a strbuf to create the tmpdir path

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 19, 2021, 18:46 UTC
Message-ID: <d882e3a7-d459-5063-eca7-e77e1addfed5@kdbg.org>
In-Reply-To: <CAJDDKr6AM0YZ-5GmXHz=2VbRKOusjQ-OAP2ng8GpBDb0x1pPRg@mail.gmail.com>

Am 19.09.21 um 20:13 schrieb David Aguilar:

Show 9 quoted lines

> A better title might be:
> 
>     difftool: use a strbuf to generate a tmpdir path without double-slashes
> 
> The double-slashes are the point. This patch is a minor cleanup that I
> found on the path towards fixing the data loss bug in patch 4.
> 
> Thanks for the heads-up about the confusion ~ I'll reword in the next
> submission to make this point clearer.

Thanks. My primary concern with the patch was actually that it looks like mere code churn that introduces an error by not using is_dir_sep(). This is now settled.

But still, without a justification why the slashes should be cleaned up, the patch looks like code churn. You can ignore me if it is obvious for others why we need the patch.

-- Hannes