git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] t7800-difftool: cleanup temporary repositories used by tests

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 19, 2021, 13:25 UTC
Message-ID
<875yuwd7a8.fsf@evledraar.gmail.com>
In-Reply-To
<20210919015729.98323-1-davvid@gmail.com>
On Sat, Sep 18 2021, David Aguilar wrote:
> The "dirlinks" and "growing" repositories should not outlive the
> tests that use them.

Why not? The pattern of not bothering to clean up the work scratch are is fine as long as it doesn't leave crap around for other tests. See the referenec to "repo" at[1].

I.e. is this needed for later tests that change in this series, or just cleanup in case a future test ever cares that there's an untracked "dirlinks" and "growing" directory at the top-level?

1. https://lore.kernel.org/git/87y27veeyj.fsf@evledraar.gmail.com/
Previous: David AguilarNext: Junio C Hamano
Message 15 of 16 in “t7800-difftool: cleanup temporary repositories used by tests”
  1. 1/4 t7800-difftool: cleanup temporary repositories used by testsDavid Aguilar, Sep 19, 2021
  2. 2/4 difftool: add a missing space to the run_dir_diff() commentsDavid Aguilar, Sep 19, 2021
  3. 3/4 difftool: use a strbuf to create the tmpdir pathDavid Aguilar, Sep 19, 2021
  4. Jeff KingSep 19, 2021
  5. 3/4 difftool: use a strbuf to create the tmpdir pathDavid Aguilar, Sep 19, 2021
  6. Junio C HamanoSep 20, 2021
  7. Johannes SixtSep 19, 2021
  8. David AguilarSep 19, 2021
  9. Johannes SixtSep 19, 2021
  10. David AguilarSep 19, 2021
  11. Johannes SixtSep 19, 2021
  12. 4/4 difftool: fix symlink-file writing in dir-diff modeDavid Aguilar, Sep 19, 2021
  13. 4/4 difftool: fix symlink-file writing in dir-diff modeDavid Aguilar, Sep 19, 2021
  14. 4/4 difftool: fix symlink-file writing in dir-diff modeDavid Aguilar, Sep 19, 2021
  15. Ævar Arnfjörð BjarmasonSep 19, 2021
  16. Junio C HamanoSep 20, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.