Re: [PATCH 4/4] dir.c: avoid "exceeds maximum object size" error with GCC v12.x
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- May 25, 2022, 13:39 UTC
- Message-ID
- <d7ee0bf0-22bc-d494-2699-7075fc92f28a@github.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2205242302020.352@tvgsbejvaqbjf.bet>
On 5/24/2022 5:05 PM, Johannes Schindelin wrote:> On Tue, 24 May 2022, Ævar Arnfjörð Bjarmason wrote:
Show 16 quoted lines
>> On Tue, May 24 2022, Johannes Schindelin via GitGitGadget wrote:
>>> + /*
>>> + * It should not be possible to overflow `ptrdiff_t` by passing in an
>>> + * insanely long URL, but GCC does not know that and will complain
>>> + * without this check.
>>> + */
>>> + if (end - start < 0)
>>> + die(_("No directory name could be guessed.\n"
>>
>> This should start with a lower-case letter, see CodingGuidelines.
>
> This message is copied from existing code later in the same function.
> Since it is a translateable message, I do not want to edit it because that
> would cause unnecessary work of the translators. Especially given that we
> do not even expect this message to be shown, ever, but we only add this
> hunk for GCC's benefit.Perhaps this should be a BUG() statement, then? Without any translation?
Thanks, -Stolee