Re: [PATCH 2/4] nedmalloc: avoid new compile error

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 24, 2022, 21:33 UTC
Message-ID: <220524.86ee0ivch2.gmgdl@evledraar.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2205242239150.352@tvgsbejvaqbjf.bet>

On Tue, May 24 2022, Johannes Schindelin wrote:

Show 21 quoted lines

> Hi René,
>
> On Tue, 24 May 2022, René Scharfe wrote:
>
>> Am 24.05.22 um 10:00 schrieb Ævar Arnfjörð Bjarmason:
>> >
>> > This seems sensible, I thought "why not submit it to upstream",
>> > i.e. see:
>> > https://github.com/ned14/nedmalloc/blob/master/nedmalloc.c#L1298
>> >
>> > But that repository was last updated in 2014, I wonder if it's just
>> > because nobody's submitted a patch since then, or if it's inactive. Have
>> > you tried making Njall Douglas (the nedmalloc author) aware of this
>> > issue?
>> >
>>
>> https://github.com/ned14/nedmalloc says at the top: "This repository has
>> been archived by the owner. It is now read-only.".
>
> Indeed, maintenance of nedmalloc has stopped a few years ago (see e.g.
> https://github.com/ned14/nedmalloc/issues/20#issuecomment-343432314).

The author says:

    nedmalloc is pretty much EOL. Happy to accept patches, but unwilling to fix.

The "Happy to accept patches" seems to suggest that they're willing to take a PR, just not willing to do spend time on it themselves.

Anyway, I see that we've accumulated quite a few patches on top, and given...

> About five years ago I tried to upgrade us to the latest nedmalloc version
> but ran into a performance regression that I was unable to justify the
> time to investigate further.

...perhaps it's not worth it.

Maybe someone should get to updating the readme we carry from it to change the first line from:

    nedalloc v1.05 15th June 2008:

To:

    Git's (perma-)fork & local hacks on top of nedalloc v1.05 15th June 2008:

Or something :)