Re: [PATCH v2 24/24] refs/files-backend: convert static functions to object_id

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Oct 11, 2017, 08:36 UTC
Message-ID: <d6e20486-af67-412f-4140-6ac38b8be7c6@alum.mit.edu>
In-Reply-To: <20171009011132.675341-25-sandals@crustytoothpaste.net>

On 10/09/2017 03:11 AM, brian m. carlson wrote:

Show 17 quoted lines

> Convert several static functions to take pointers to struct object_id.
> Change the relevant parameters to write_packed_entry to be const, as we
> don't modify them.  Rename lock_ref_sha1_basic to lock_ref_oid_basic to
> reflect its new argument.
> 
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  refs/files-backend.c | 48 ++++++++++++++++++++++++------------------------
>  1 file changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/refs/files-backend.c b/refs/files-backend.c
> index 7281f27f62..84d8e3da99 100644
> --- a/refs/files-backend.c
> +++ b/refs/files-backend.c
> @@ -811,7 +811,7 @@ static struct ref_iterator *files_ref_iterator_begin(
>   * return a negative value.
>   */

The docstring for this function needs adjusting. It would also be worth mentioning that `old_oid` is allowed to be NULL (which was true before but wasn't mentioned).

> [...]

Michael