Re: [PATCH] valgrind: support test helpers

From: René Scharfe <l.s.r@web.de>
Date: Oct 29, 2016, 09:43 UTC
Message-ID: <d6485418-e009-f808-8ee2-a06e60c60d0d@web.de>
In-Reply-To: <xmqqshrg3af4.fsf@gitster.mtv.corp.google.com>

Am 28.10.2016 um 14:50 schrieb Junio C Hamano:

> Hmph.  I somehow thought this was supposed to have been fixed by
> 503e224180 ("t/test-lib.sh: fix running tests with --valgrind",
> 2016-07-11) already.

Its title seems to indicate that intention. Probably the quickest test script that calls a helper is t0009-prio-queue.sh, and without my patch it reports something like this, unfortunately:

  expecting success:
          test-prio-queue 2 6 3 10 9 5 7 4 5 8 1 dump >actual &&
          test_cmp expect actual
  
  ./t0009-prio-queue.sh: 4: eval: test-prio-queue: not found
  not ok 1 - basic ordering
  #
  #               test-prio-queue 2 6 3 10 9 5 7 4 5 8 1 dump >actual &&
  #               test_cmp expect actual
  #

René