Re: [PATCH] valgrind: support test helpers
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 28, 2016, 08:51 UTC
- Message-ID
- <alpine.DEB.2.20.1610281050220.3264@virtualbox>
- In-Reply-To
- <71c3d13a-fa29-75d3-50ac-81978c08f552@web.de>
Hi,
On Fri, 28 Oct 2016, René Scharfe wrote:
Show 11 quoted lines
> Tests run with --valgrind call git commands through a wrapper script > that invokes valgrind on them. This script (valgrind.sh) is in turn > invoked through symlinks created for each command in t/valgrind/bin/. > > Since e6e7530d (test helpers: move test-* to t/helper/ subdirectory) > these symlinks have been broken for test helpers -- they point to the > old locations in the root of the build directory. Fix that by teaching > the code for creating the links about the new location of the binaries, > and do the same in the wrapper script to allow it to find its payload. > > Signed-off-by: Rene Scharfe <l.s.r@web.de>
Apart from the missing accent ("é") in your SOB: ACK.Ciao, Dscho