Re: [PATCH v4 00/11] doc: interpret-trailers: explain key format
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Aug 8, 2026, 20:02 UTC
- Message-ID
- <d60621cd-79cb-4fac-bc0b-828e29131043@app.fastmail.com>
- In-Reply-To
- <xmqqldajhv9q.fsf@gitster.g>
On Thu, Aug 6, 2026, at 22:02, Junio C Hamano wrote:
Show 17 quoted lines
> "D. Ben Knoble" <ben.knoble@gmail.com> writes:
>
>> One small comment on patch 4
>> ...
>> A few places we use an inline list syntax ("… (i) stuff … (ii) more
>> stuff …"). In the added example about ASCII trailers it is useful
>> because we make reference to (ii); in the initial part of the manual,
>> I don't see any references to the delimited items, so I'm not sure if
>> it's worth numbering them.
>>
>> Not a strong statement, though, so I'm happy either way. Everything
>> else (that I looked at, see above) looks good to me.
>
> I guess we are gettng very close to the finish line. Kristoffer,
> how would we want to proceed?
>
> Thanks, both.I will wait at least one day for any more comments and post a new version with that fix that Knoble found to the commit message.