Re: [PATCH v3 02/11] doc: interpret-trailers: replace “lines” with “metadata”
- From
Matt Hunter <m@lfurio.us>
- Date
- Jun 16, 2026, 21:39 UTC
- Message-ID
- <DJASSI4SSB3E.3JDRTZ3UNTSC4@lfurio.us>
- In-Reply-To
- <26c2fcb2-2618-4bb9-a6e4-a6135934556d@app.fastmail.com>
On Tue Jun 16, 2026 at 4:32 PM EDT, Kristoffer Haugsbakk wrote:
Show 12 quoted lines
> On Thu, Jun 11, 2026, at 05:10, Matt Hunter wrote: >> On Wed Jun 10, 2026 at 5:21 PM EDT, kristofferhaugsbakk wrote: >>>[snip] >>> DESCRIPTION >>> ----------- >>> -Add or parse _trailer_ lines at the end of the otherwise >>> +Add or parse trailers metadata at the end of the otherwise >> >> fwiw, I think "trailer metadata" reads more naturally. > > You’re right that your version reads more naturally. I went back and > forth on this.
After reading your points, I started debating the grammatical correctness of it to myself too. Though I think I stand by my original knee-jerk response.
Show 13 quoted lines
> > 1. We’re introducing the jargon, and the format is often discussed as > plural “trailers”, with its constituent parts being singular > “trailer” > 2. What this replaces uses “trailer”, but it rescues the plural mood > with “lines” > 3. This is very soon going to go into the constituent parts, including > each trailer, so we’re contrasting the concept name (trailers) with > its parts > > But I think your version is overall better. It reads better and there is > no way to confuse “trailer metadata” (trailers as a collection) with > just a single “trailer”.
Yes, "metadata" reads as a hint to me that interpret-trailers works with the overall trailer block too.
Another thought I had after seeing this again is that the text could just say "Add or parse trailers at the end ...", but "metadata" is a lot more useful, since it's an introduction to what trailers _are_. So the patch is an improvement over the original context imo.