git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-cvsserver: handle CVS 'noop' command.

From
Stefan Karpinski <stefan.karpinski@gmail.com>
Date
Jan 29, 2009, 23:39 UTC
Message-ID
<d4bc1a2a0901291539m636f0fc8s5d9280ce9b7d22b2@mail.gmail.com>
In-Reply-To
<7v7i4denpg.fsf@gitster.siamese.dyndns.org>
On Thu, Jan 29, 2009 at 2:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
>
> Imagine what you would do when you discover another request a random other
> client sends that you would want to ignore just like you did for 'noop'.
> Viewed in this light, your patch is a very short sighted one that has a
> big negative impact on maintainability.

Fair enough. I was trying to change the minimal amount that I could and still fix the breakage. Your patch is much better. Not to mention terser ;-)

Show 8 quoted lines
> A true no-brainer that has no negative impact would have been something
> like the attached patch, that adds a method that does not do anything.
>
> Even then, between req_CATCHALL and req_EMPTY, I am not sure which one is
> expected by the clients, without consulting to the protocol documentation
> for cvs server/client communication.  In the attached patch, I am guessing
> from your patch that at least Tortoise does not expect any response to
> it.

I have consulted the CVS protocol documentation (found at http://www.wandisco.com/techpubs/cvs-protocol.pdf), which states the following about the "noop" command:

"Response expected: yes. This request is a null command in the sense that it doesn't do anything, but merely (as with any other requests expecting a response) sends back any responses pertaining to pending errors, pending Notified responses, etc."

So apparently a response *is* expected. I'm not really familiar enough with CVS or git-cvsserver to determine what that means it should do, but I suspect from perusing the code that req_EMPTY is the appropriate action.

Moreover, I've moved on from using git-cvsserver myself, having instead convinced my Windows-using compatriots to use msysgit instead. So if you feel that this change is unwarranted, feel free to just drop it.

Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 12 in “Re: [PATCH] git-cvsserver: run post-update hook *after* update.”
  1. Stefan KarpinskiJan 23, 2009
  2. Junio C HamanoJan 23, 2009
  3. git-cvsserver: run post-update hook *after* update.Stefan Karpinski, Jan 29, 2009
  4. Junio C HamanoJan 29, 2009
  5. Stefan KarpinskiJan 29, 2009
  6. Andy ParkinsJan 29, 2009
  7. git-cvsserver: handle CVS 'noop' command.Stefan Karpinski, Jan 29, 2009
  8. Junio C HamanoJan 29, 2009
  9. Stefan KarpinskiJan 29, 2009
  10. Junio C HamanoJan 29, 2009
  11. git-cvsserver: handle CVS 'noop' command.Stefan Karpinski, Jan 30, 2009
  12. Martin LanghoffJan 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.