Re: [PATCH] git-cvsserver: handle CVS 'noop' command.

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2009, 23:46 UTC
Message-ID: <7vhc3hd6ba.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <d4bc1a2a0901291539m636f0fc8s5d9280ce9b7d22b2@mail.gmail.com>

Stefan Karpinski <stefan.karpinski@gmail.com> writes:

Show 9 quoted lines

> So apparently a response *is* expected. I'm not really familiar enough
> with CVS or git-cvsserver to determine what that means it should do,
> but I suspect from perusing the code that req_EMPTY is the appropriate
> action.
>
> Moreover, I've moved on from using git-cvsserver myself, having
> instead convinced my Windows-using compatriots to use msysgit instead.
> So if you feel that this change is unwarranted, feel free to just drop
> it.

Because the issue currently has our attention, and we think we know that the code does not do the right thing currently, and that we are fairly sure that the right thing is to do req_EMPTY, I'd rather see a tested fix applied so that we can forget about it ;-)

It's good that you moved your people to native git environment, but if you have an environment where you can test the fix still lying around, I'd appreciate a quick test and resubmit.