Re: [PATCH 2/2] pack documentation review updates
- From
Scott Chacon <schacon@gmail.com>
- Date
- Nov 11, 2009, 10:05 UTC
- Message-ID
- <d411cc4a0911110205j6f3afedw57d2c56fb28dc20@mail.gmail.com>
- In-Reply-To
- <20091111171924.6117@nanako3.lavabit.com>
Hey,
On Wed, Nov 11, 2009 at 9:19 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:
Show 19 quoted lines
> Update Scott's protocol document according to review comments given by Junio. > > * name of "%00" byte is NUL not null; > * requestee sends current values of its refs, not "known values"; > * consistently use "obj-id"; > * requestor chooses the capabilities it wants to be in effect; > * pack data is sent after negotiation finishes, not just after "some of > it is done"; > * what it has is called "its", not "it's"; > * consistently use "flush-pkt"; > * remove redundant "something like"; > * status report for send-pack is sent from the receiver, not from client; > * don't unnecessarily say "SHOULD NOT" when existing servers can satisify > "MUST NOT"; > * only one thin pack is sent and thickened; > * an all-zero value is defined as a zero-id, so use it. > > Signed-off-by: しらいし ななこ <nanako3@lavabit.com> > ---
I was _just_ working on this yesterday and had gotten about halfway through - I'm traveling a lot right now, so I'm a bit behind. This looks good, thanks for taking the time Nanako.
Signed-off-by: Scott Chacon <schacon@gmail.com>