Re: [PATCH 2/2] pack documentation review updates

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 15, 2009, 09:11 UTC
Message-ID: <7vd43kqhib.fsf@alter.siamese.dyndns.org>
In-Reply-To: <d411cc4a0911110205j6f3afedw57d2c56fb28dc20@mail.gmail.com>

Scott Chacon <schacon@gmail.com> writes:

Show 14 quoted lines

> On Wed, Nov 11, 2009 at 9:19 AM, Nanako Shiraishi <nanako3@lavabit.com> wrote:
>> Update Scott's protocol document according to review comments given by Junio.
>>
>>  * name of "%00" byte is NUL not null;
>> ...
>>  * don't unnecessarily say "SHOULD NOT" when existing servers can satisify
>>   "MUST NOT";
>> ...
>
> I was _just_ working on this yesterday and had gotten about halfway
> through - I'm traveling a lot right now, so I'm a bit behind.  This
> looks good, thanks for taking the time Nanako.
>
> Signed-off-by: Scott Chacon <schacon@gmail.com>

Thanks, both.

I had some doubts about the "SHOULD NOT"/"MUST" on obj-id myself, but if you are Ok with the change, I wouldn't complain ;-).

Will squash this in.