git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin/repack.c: only collect fully-formed packs

From
Derrick Stolee <derrickstolee@github.com>
Date
Jun 7, 2023, 13:51 UTC
Message-ID
<d3c67344-a10d-f680-4601-581138985006@github.com>
In-Reply-To
<dda5a34a3e879787ce8651674962db6cf913b7b2.1686132967.git.me@ttaylorr.com>
On 6/7/2023 6:16 AM, Taylor Blau wrote:
> To partition the set of packs based on which ones are "kept" (either
> they have a .keep file, or were otherwise marked via the `--keep-pack`
> option) and "non-kept" ones (anything else), `git repack` uses its
> `collect_pack_filenames()` function.
...
> Fix the above by teaching `collect_pack_filenames()` to only collect
> packs with their corresponding `*.idx` files in place, indicating that
> those packs have been fully staged.

I reviewed an internal version of this patch, so I'm happy with this version. I'd be very interested if anyone has concerns with the approach, though.

Thanks, -Stolee

Previous: Taylor Blau
Message 2 of 2 in “builtin/repack.c: only collect fully-formed packs”
  1. builtin/repack.c: only collect fully-formed packsTaylor Blau, Jun 7, 2023
  2. Derrick StoleeJun 7, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.