From: Derrick Stolee <derrickstolee@github.com>
Date: Wed, 07 Jun 2023 13:51:22 GMT
Subject: Re: [PATCH] builtin/repack.c: only collect fully-formed packs
Message-ID: <d3c67344-a10d-f680-4601-581138985006@github.com>
In-Reply-To: <dda5a34a3e879787ce8651674962db6cf913b7b2.1686132967.git.me@ttaylorr.com>

On 6/7/2023 6:16 AM, Taylor Blau wrote:
> To partition the set of packs based on which ones are "kept" (either
> they have a .keep file, or were otherwise marked via the `--keep-pack`
> option) and "non-kept" ones (anything else), `git repack` uses its
> `collect_pack_filenames()` function.

...

> Fix the above by teaching `collect_pack_filenames()` to only collect
> packs with their corresponding `*.idx` files in place, indicating that
> those packs have been fully staged.

I reviewed an internal version of this patch, so I'm happy with this
version. I'd be very interested if anyone has concerns with the
approach, though.

Thanks,
-Stolee