git/list[1] front-page[2] threads[3] people[4] search[5] about
 

t0612: mark as leak-free

From
Rubén Justo <rjusto@gmail.com>
Date
Jul 1, 2024, 19:38 UTC
Message-ID
<d244fb44-0bd2-4416-b24c-0a93835b75a4@gmail.com>
In-Reply-To
<7ef69875-b18f-4ccb-be83-e994315636bd@gmail.com>
A quick test tell us that t0612 does not trigger any leak:
    $ make SANITIZE=leak test GIT_TEST_PASSING_SANITIZE_LEAK=check GIT_TEST_SANITIZE_LEAK_LOG=true GIT_TEST_OPTS=-i T=t0612-reftable-jgit-compatibility.sh
    [...]
    *** t0612-reftable-jgit-compatibility.sh ***
    in GIT_TEST_PASSING_SANITIZE_LEAK=check mode, setting --invert-exit-code for TEST_PASSES_SANITIZE_LEAK != true
    ok 1 - CGit repository can be read by JGit
    ok 2 - JGit repository can be read by CGit
    ok 3 - mixed writes from JGit and CGit
    ok 4 - JGit can read multi-level index
    # passed all 4 test(s)
    1..4
    # faking up non-zero exit with --invert-exit-code
    make[2]: *** [Makefile:75: t0612-reftable-jgit-compatibility.sh] Error 1

Let's mark it as leak-free to silence the machinery activated by `GIT_TEST_PASSING_SANITIZE_LEAK=check`.

Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Rubén Justo <rjusto@gmail.com>
---
 t/t0612-reftable-jgit-compatibility.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/t0612-reftable-jgit-compatibility.sh b/t/t0612-reftable-jgit-compatibility.sh
index d0d7e80b49..84922153ab 100755
--- a/t/t0612-reftable-jgit-compatibility.sh
+++ b/t/t0612-reftable-jgit-compatibility.sh
@@ -11,6 +11,7 @@ export GIT_TEST_DEFAULT_REF_FORMAT
 GIT_TEST_SPLIT_INDEX=0
 export GIT_TEST_SPLIT_INDEX
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 if ! test_have_prereq JGIT
-- 
2.45.1
Previous: Rubén JustoNext: Eric Sunshine
Message 4 of 11 in “t0613: mark as leak-free”
  1. t0613: mark as leak-freeRubén Justo, Jun 30, 2024
  2. Jeff KingJul 1, 2024
  3. Rubén JustoJul 1, 2024
  4. t0612: mark as leak-freeRubén Justo, Jul 1, 2024
  5. Eric SunshineJul 1, 2024
  6. t0612: mark as leak-freeRubén Justo, Jul 1, 2024
  7. Patrick SteinhardtJul 22, 2024
  8. Jeff KingJul 23, 2024
  9. Re* [PATCH] t0613: mark as leak-freeRubén Justo, Jul 23, 2024
  10. Patrick SteinhardtJul 24, 2024
  11. Rubén JustoJul 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.