Re: [PATCH] t0613: mark as leak-free

From: Jeff King <peff@peff.net>
Date: Jul 1, 2024, 03:57 UTC
Message-ID: <20240701035759.GF610406@coredump.intra.peff.net>
In-Reply-To: <23d41343-54fd-46c6-9d78-369e8009fa0b@gmail.com>

On Sun, Jun 30, 2024 at 08:46:38AM +0200, Rubén Justo wrote:

Show 6 quoted lines

> We can mark t0613 as leak-free:
> [...]
> I'm not sure why this simple change has fallen through the cracks.
> Therefore, it's possible that I'm missing something.
> 
> I'd appreciate if someone could double-check.

I'd noticed it, too, while doing recent leak fixes. But since Patrick has been working on leaks and is the go-to person for reftables, I assumed he had already seen it and there was something clever going on. ;)

I also get a passing result from t0612 (and I do have JGit available, so it actually runs the tests).

I also get funny results from t4255, but I think we can ignore them. It's known breakages vanishing, which I guess is just some sub-program returning failure due to a leak and changing the test results.

So anyway, this patch looks good to me, but probably we could squash t0612 into it, as well.

-Peff