[PATCH 0/6] pack-bitmap: miscellaneous mmap read hardening
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Mar 20, 2023, 20:02 UTC
- Message-ID
- <cover.1679342296.git.me@ttaylorr.com>
This short series has a few minor refactorings and hardenings I noticed while reading the pack-bitmap.c code recently.
The series is structured as follows:
- The first three are cleanups to the read_be32() and read_u8()
functions that could be taken on their own. - The last three replace manually reading from `bitmap_git->map` and
adjusting `bitmap_git->map_pos` accordingly with a new
`bitmap_index_seek()` wrapper that accomplishes the same with
additional bounds- and overflow-checking.Thanks in advance for your review.
Taylor Blau (6): pack-bitmap.c: hide bitmap internals in `read_u8()` pack-bitmap.c: hide bitmap internals in `read_be32()` pack-bitmap.c: drop unnecessary 'inline's pack-bitmap.c: factor out manual `map_pos` manipulation pack-bitmap.c: use `bitmap_index_seek()` where possible pack-bitmap.c: factor out `bitmap_index_seek_commit()`
pack-bitmap.c | 84 ++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 59 insertions(+), 25 deletions(-)
-- 2.40.0.77.gd564125b3f