Re: [PATCH 5/6] pack-bitmap.c: use `bitmap_index_seek()` where possible

> Jeff King <peff@peff.net> writes:
>
> > Yes, I think the SEEK_SET cases really do need to be doing more
> > checking. AFAICT they are blindly trusting the offsets in the file
> > (which is locally generated, so it's more of a corruption problem than a
> > security one, but still). And this series improves that, which is good
> > (but I still think it should be a die() and not a BUG()).
>
> Yes, I think by mistake I merged the topic way too early than it has
> been discussed sufficiently.  I haven't reverted the merge into 'next'
> but it may not be a bad idea if the concensus is that the seek-like
> whence interface is too ugly to live.  BUG() that triggers on data
> errors should be updated to die(), whether we do it as a follow-on
> patch or with a replacement iteration.