git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 0/3] Teach submodule set-branch subcommand

From
Denton Liu <liu.denton@gmail.com>
Date
Feb 8, 2019, 11:21 UTC
Message-ID
<cover.1549624679.git.liu.denton@gmail.com>
In-Reply-To
<cover.1549534460.git.liu.denton@gmail.com>

Thanks so much for the feedback, Junio. I've updated the patchset based on your comments.

Currently, there is no way to set the branch of a submodule without manually manipulating the .gitmodules file. This patchset introduces a porcelain command that enables this.

Changes since v1:
	* Fixed incorrect usage of OPT_CMDMODE
Changes since v2:
	* Corrected missing argument for -b/--branch in git-submodule.txt
	* Rebased onto latest next
Changes since v3:
	* Rebased back onto master
	* Address Junio's comments and improve clarity of submodule--helper patch
	* Fix incorrect documentation formatting in git-submodule.txt
Denton Liu (3):
  git-submodule.txt: "--branch <branch>" option defaults to 'master'
  submodule--helper: teach config subcommand --unset
  submodule: teach set-branch subcommand
 Documentation/git-submodule.txt        | 14 +++-
 builtin/submodule--helper.c            | 17 +++--
 contrib/completion/git-completion.bash |  5 +-
 git-submodule.sh                       | 75 +++++++++++++++++++--
 t/t7411-submodule-config.sh            |  9 +++
 t/t7419-submodule-set-branch.sh        | 93 ++++++++++++++++++++++++++
 6 files changed, 200 insertions(+), 13 deletions(-)
 create mode 100755 t/t7419-submodule-set-branch.sh
-- 
2.20.1.522.g5f42c252e9
Previous: Junio C HamanoNext: Denton Liu
Message 21 of 25 in “Teach submodule set-branch subcommand”
  1. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 6, 2019
  2. 1/3 git-submodule.txt: document default behavior without --branchDenton Liu, Feb 6, 2019
  3. Junio C HamanoFeb 6, 2019
  4. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 6, 2019
  5. Junio C HamanoFeb 6, 2019
  6. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 6, 2019
  7. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 7, 2019
  8. 1/3 git-submodule.txt: document default behavior without --branchDenton Liu, Feb 7, 2019
  9. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 7, 2019
  10. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 7, 2019
  11. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 7, 2019
  12. 1/3 git-submodule.txt: "--branch <branch>" option defaults to 'master'Denton Liu, Feb 7, 2019
  13. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 7, 2019
  14. Junio C HamanoFeb 7, 2019
  15. Junio C HamanoFeb 7, 2019
  16. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 7, 2019
  17. Junio C HamanoFeb 7, 2019
  18. Junio C HamanoFeb 7, 2019
  19. Denton LiuFeb 8, 2019
  20. Junio C HamanoFeb 8, 2019
  21. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 8, 2019
  22. 1/3 git-submodule.txt: "--branch <branch>" option defaults to 'master'Denton Liu, Feb 8, 2019
  23. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 8, 2019
  24. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 8, 2019
  25. Denton LiuFeb 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.