git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3] Teach submodule set-branch subcommand

From
Denton Liu <liu.denton@gmail.com>
Date
Feb 8, 2019, 05:31 UTC
Message-ID
<20190208053152.GA3378@archbookpro.localdomain>
In-Reply-To
<xmqqo97npjej.fsf@gitster-ct.c.googlers.com>
On Thu, Feb 07, 2019 at 10:01:40AM -0800, Junio C Hamano wrote:
Show 26 quoted lines
> Denton Liu <liu.denton@gmail.com> writes:
> 
> > I rebased the changes onto the latest 'next' because if this branch gets
> > merged into 'next', there'll be merge conflicts from
> > 'dl/complete-submodule-absorbgitdirs'.
> 
> Please don't do that.
> 
> A topic that depends on everything in 'next' cannot graduate to
> 'master' until everything that is cooking in 'next' does.
> 
> When
> 
>  - the "conflict" that would arise is so trivial to resolve,
> 
>  - there is no semantic crashes between the new topic and existing
>     ones, and
> 
>  - the topic is usable even before other topics graduate (or even
>    when they get discarded)
> 
> please make it a habit to avoid making your topic (i.e. this one)
> hostage to another topic (i.e. the absorbgitdirs one), and certainly
> not hostage to the whole of 'next'.  A trivial conflict resolution
> in this case, if you revert the rebasing and then attempt to merge
> the result to 'next', would look like this.

My mistake, even though I've made a few contributions already, I'm still getting used to the git.git workflow.

Thanks so much for helping me out and please don't hesitate to let me know if I'm doing anything else wrong.

By the way, just for the record, how would you like me to handle patchsets that cause merge conflicts?

Thanks,
Denton
Previous: Junio C HamanoNext: Junio C Hamano
Message 19 of 25 in “Teach submodule set-branch subcommand”
  1. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 6, 2019
  2. 1/3 git-submodule.txt: document default behavior without --branchDenton Liu, Feb 6, 2019
  3. Junio C HamanoFeb 6, 2019
  4. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 6, 2019
  5. Junio C HamanoFeb 6, 2019
  6. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 6, 2019
  7. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 7, 2019
  8. 1/3 git-submodule.txt: document default behavior without --branchDenton Liu, Feb 7, 2019
  9. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 7, 2019
  10. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 7, 2019
  11. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 7, 2019
  12. 1/3 git-submodule.txt: "--branch <branch>" option defaults to 'master'Denton Liu, Feb 7, 2019
  13. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 7, 2019
  14. Junio C HamanoFeb 7, 2019
  15. Junio C HamanoFeb 7, 2019
  16. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 7, 2019
  17. Junio C HamanoFeb 7, 2019
  18. Junio C HamanoFeb 7, 2019
  19. Denton LiuFeb 8, 2019
  20. Junio C HamanoFeb 8, 2019
  21. 0/3 Teach submodule set-branch subcommandDenton Liu, Feb 8, 2019
  22. 1/3 git-submodule.txt: "--branch <branch>" option defaults to 'master'Denton Liu, Feb 8, 2019
  23. 2/3 submodule--helper: teach config subcommand --unsetDenton Liu, Feb 8, 2019
  24. 3/3 submodule: teach set-branch subcommandDenton Liu, Feb 8, 2019
  25. Denton LiuFeb 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.