git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Do not lock temporary files via child processes on Windows

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 17, 2016, 12:40 UTC
Message-ID
<cover.1471437637.git.johannes.schindelin@gmx.de>

This issue was originally reported and fixed in https://github.com/git-for-windows/git/pull/755

The problem is that file handles to temporary files (such as index.lock) were inherited by spawned processes. If those spawned processes do not exit before the parent process wants to delete or rename them, we are in big trouble.

The original use case triggering the bug is a merge driver that does not quit, but listen to subsequent merge requests.

However, the same issue turned up in Lars Schneider's work on making clean/smudge filters batchable (i.e. more efficient by avoiding possibly thousands of child processes, one per file).

Ben Wijen (2):
  t6026-merge-attr: child processes must not inherit index.lock handles
  mingw: ensure temporary file handles are not inherited by child
    processes
 compat/mingw.h        |  4 ++++
 t/t6026-merge-attr.sh | 13 +++++++++++++
 tempfile.c            |  2 +-
 3 files changed, 18 insertions(+), 1 deletion(-)
Published-As: https://github.com/dscho/git/releases/tag/mingw-index-lock-v1
Fetch-It-Via: git fetch https://github.com/dscho/git mingw-index-lock-v1
-- 
2.9.2.691.g78954f3

base-commit: 07c92928f2b782330df6e78dd9d019e984d820a7
Next: Johannes Schindelin
Message 1 of 21 in “Do not lock temporary files via child processes on Windows”
  1. 0/2 Do not lock temporary files via child processes on WindowsJohannes Schindelin, Aug 17, 2016
  2. 1/2 t6026-merge-attr: child processes must not inherit index.lock handlesJohannes Schindelin, Aug 17, 2016
  3. Junio C HamanoAug 17, 2016
  4. 2/2 mingw: ensure temporary file handles are not inherited by child processesJohannes Schindelin, Aug 17, 2016
  5. Eric SunshineAug 17, 2016
  6. Johannes SchindelinAug 18, 2016
  7. Lars SchneiderAug 17, 2016
  8. Junio C HamanoAug 17, 2016
  9. Johannes SchindelinAug 18, 2016
  10. Eric WongAug 18, 2016
  11. Junio C HamanoAug 18, 2016
  12. Eric WongAug 18, 2016
  13. Junio C HamanoAug 19, 2016
  14. Johannes SchindelinAug 22, 2016
  15. 0/2 Do not lock temporary files via child processes on WindowsJohannes Schindelin, Aug 18, 2016
  16. 2/2 mingw: ensure temporary file handles are not inherited by child processesJohannes Schindelin, Aug 18, 2016
  17. 1/2 t6026-merge-attr: child processes must not inherit index.lock handlesJohannes Schindelin, Aug 18, 2016
  18. 0/2 Do not lock temporary files via child processes on WindowsJohannes Schindelin, Aug 22, 2016
  19. 1/2 t6026-merge-attr: child processes must not inherit index.lock handlesJohannes Schindelin, Aug 22, 2016
  20. 2/2 mingw: ensure temporary file handles are not inherited by child processesJohannes Schindelin, Aug 22, 2016
  21. Eric WongAug 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.