git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] mingw: ensure temporary file handles are not inherited by child processes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 22, 2016, 12:47 UTC
Message-ID
<alpine.DEB.2.20.1608221443170.4924@virtualbox>
In-Reply-To
<xmqqbn0o4uq2.fsf@gitster.mtv.corp.google.com>
Hi,
On Fri, 19 Aug 2016, Junio C Hamano wrote:
Show 8 quoted lines
> Eric Wong <e@80x24.org> writes:
> 
> > I'd be more comfortable keeping the EINVAL check that got
> > snipped in your reply.  O_CLOEXEC can be defined to non-zero in
> > new userspace headers, but an older kernel chokes on it with
> > EINVAL.
> 
> Good point.  Thanks.

I tried to accomodate both of your suggestions by defining O_CLOEXEC in git-compat-util.h unless defined earlier, and by handling EINVAL via dropping O_CLOEXEC in a second call to open(). Please inspect the interdiff of the upcoming iteration.

Ciao, Dscho

Previous: Junio C HamanoNext: Johannes Schindelin
Message 14 of 21 in “Do not lock temporary files via child processes on Windows”
  1. 0/2 Do not lock temporary files via child processes on WindowsJohannes Schindelin, Aug 17, 2016
  2. 1/2 t6026-merge-attr: child processes must not inherit index.lock handlesJohannes Schindelin, Aug 17, 2016
  3. Junio C HamanoAug 17, 2016
  4. 2/2 mingw: ensure temporary file handles are not inherited by child processesJohannes Schindelin, Aug 17, 2016
  5. Eric SunshineAug 17, 2016
  6. Johannes SchindelinAug 18, 2016
  7. Lars SchneiderAug 17, 2016
  8. Junio C HamanoAug 17, 2016
  9. Johannes SchindelinAug 18, 2016
  10. Eric WongAug 18, 2016
  11. Junio C HamanoAug 18, 2016
  12. Eric WongAug 18, 2016
  13. Junio C HamanoAug 19, 2016
  14. Johannes SchindelinAug 22, 2016
  15. 0/2 Do not lock temporary files via child processes on WindowsJohannes Schindelin, Aug 18, 2016
  16. 2/2 mingw: ensure temporary file handles are not inherited by child processesJohannes Schindelin, Aug 18, 2016
  17. 1/2 t6026-merge-attr: child processes must not inherit index.lock handlesJohannes Schindelin, Aug 18, 2016
  18. 0/2 Do not lock temporary files via child processes on WindowsJohannes Schindelin, Aug 22, 2016
  19. 1/2 t6026-merge-attr: child processes must not inherit index.lock handlesJohannes Schindelin, Aug 22, 2016
  20. 2/2 mingw: ensure temporary file handles are not inherited by child processesJohannes Schindelin, Aug 22, 2016
  21. Eric WongAug 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.