git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/8] `log -c` speedup (part 2)

From
Kirill Smelkov <kirr@mns.spb.ru>
Date
Feb 3, 2014, 12:47 UTC
Message-ID
<cover.1391430523.git.kirr@mns.spb.ru>
Hello up there,

I'm still trying to speedup combined-diff to be not so slow, to be able to realistically use it in my readonly filesystem for git archives.

In the first part[1], we optimized paths intersections, but combined-diff still remained slow, because internally it was computing huge diffs, even for small, or empty output.

This time, here goes paths scanning rework, which results in significant combine-diff speedup. Please apply.

Thanks beforehand, Kirill

P.S. the code depends on ks/diff-c-with-diff-order
[1] http://permalink.gmane.org/gmane.comp.version-control.git/240713
Kirill Smelkov (8):
  fixup! combine_diff: simplify intersect_paths() further
  tests: add checking that combine-diff emits only correct paths
  tree-diff: no need to manually verify that there is no mode change for
    a path
  tree-diff: no need to pass match to skip_uninteresting()
  combine-diff: move show_log_first logic/action out of paths scanning
  combine-diff: Move changed-paths scanning logic into its own function
  combine-diff: Fast changed-to-all-parents paths scanning
  combine-diff: bail out early, if num_paths=0
 combine-diff.c                 | 215 +++++++++++++++-----
 diff.c                         |   1 +
 diff.h                         |   6 +
 t/t4057-diff-combined-paths.sh | 106 ++++++++++
 tree-diff.c                    | 442 +++++++++++++++++++++++++++++++++++++++--
 5 files changed, 696 insertions(+), 74 deletions(-)
 create mode 100755 t/t4057-diff-combined-paths.sh
-- 
1.9.rc1.181.g641f458
Next: Kirill Smelkov
Message 1 of 26 in “`log -c` speedup (part 2)”
  1. 0/8 `log -c` speedup (part 2)Kirill Smelkov, Feb 3, 2014
  2. 1/8 fixup! combine_diff: simplify intersect_paths() furtherKirill Smelkov, Feb 3, 2014
  3. Junio C HamanoFeb 3, 2014
  4. 2/8 tests: add checking that combine-diff emits only correct pathsKirill Smelkov, Feb 3, 2014
  5. Junio C HamanoFeb 3, 2014
  6. Kirill SmelkovFeb 5, 2014
  7. 3/8 tree-diff: no need to manually verify that there is no mode change for a pathKirill Smelkov, Feb 3, 2014
  8. Junio C HamanoFeb 3, 2014
  9. 4/8 tree-diff: no need to pass match to skip_uninteresting()Kirill Smelkov, Feb 3, 2014
  10. 5/8 combine-diff: move show_log_first logic/action out of paths scanningKirill Smelkov, Feb 3, 2014
  11. Junio C HamanoFeb 3, 2014
  12. 6/8 combine-diff: Move changed-paths scanning logic into its own functionKirill Smelkov, Feb 3, 2014
  13. 7/8 combine-diff: Fast changed-to-all-parents paths scanningKirill Smelkov, Feb 3, 2014
  14. Junio C HamanoFeb 3, 2014
  15. Junio C HamanoFeb 3, 2014
  16. Kirill SmelkovFeb 4, 2014
  17. Junio C HamanoFeb 4, 2014
  18. Kirill SmelkovFeb 5, 2014
  19. Junio C HamanoFeb 5, 2014
  20. Kirill SmelkovFeb 5, 2014
  21. Junio C HamanoFeb 5, 2014
  22. Kirill SmelkovFeb 5, 2014
  23. Junio C HamanoFeb 5, 2014
  24. Kirill SmelkovFeb 6, 2014
  25. Junio C HamanoFeb 4, 2014
  26. 8/8 combine-diff: bail out early, if num_paths=0Kirill Smelkov, Feb 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.