Re: [PATCH 2/8] tests: add checking that combine-diff emits only correct paths
- From
Kirill Smelkov <kirr@mns.spb.ru>
- Date
- Feb 5, 2014, 10:36 UTC
- Message-ID
- <20140205103601.GA5034@tugrik.mns.mnsspb.ru>
- In-Reply-To
- <xmqqzjm7bxny.fsf@gitster.dls.corp.google.com>
On Mon, Feb 03, 2014 at 03:10:08PM -0800, Junio C Hamano wrote:
Show 49 quoted lines
> Kirill Smelkov <kirr@mns.spb.ru> writes:
>
> > where "correct paths" stands for paths that are different to all
> > parents.
> >
> > Up until now, we were testing combined diff only on one file, or on
> > several files which were all different (t4038-diff-combined.sh).
> >
> > As recent thinko in "simplify intersect_paths() further" showed, and
> > also, since we are going to rework code for finding paths different to
> > all parents, lets write at least basic tests.
>
> Thanks. Some nitpicks.
>
> >
> > Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
> > ---
> > t/t4057-diff-combined-paths.sh | 106 +++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 106 insertions(+)
> > create mode 100755 t/t4057-diff-combined-paths.sh
> >
> > diff --git a/t/t4057-diff-combined-paths.sh b/t/t4057-diff-combined-paths.sh
> > new file mode 100755
> > index 0000000..e6e457d
> > --- /dev/null
> > +++ b/t/t4057-diff-combined-paths.sh
> > @@ -0,0 +1,106 @@
> > +#!/bin/sh
> > +
> > +test_description='combined diff show only paths that are different to all parents'
> > +
> > +. ./test-lib.sh
> > +
> > +# verify that diffc.expect matches output of
> > +# `git diff -c --name-only HEAD HEAD^ HEAD^2`
> > +diffc_verify() {
>
> Style: SP before (), i.e.
>
> diffc_verify () {
>
> > + git diff -c --name-only HEAD HEAD^ HEAD^2 >diffc.actual &&
> > + test_cmp diffc.expect diffc.actual
> > +}
> > +
> > +test_expect_success 'trivial merge - combine-diff empty' '
> > + for i in `test_seq 1 9`
>
> Style: prefer $() over ``Thanks, I've corrected the style.
Show 7 quoted lines
> > > + do > > + echo $i >$i.txt && > > + git add $i.txt > > Quiz. What happens when this "git add" fails with an earlier value > of $i?
We just continue and ignore the error = bad. On the other hand, there are a lot of places like this one in git's testsuite, and almost almost nobody cares. In a few places people add
|| exit
to last command, but I wonder, is there a way to omit the boilerplate, and also || exit is not strictly correct, as sometime we would need to analyse `for` exit code for good and also for bad, and exit just exits from shell... What would be the most convenient thing to do here?
Please find patch with style issues corrected below
Thanks, Kirill
---- 8< ----- From: Kirill Smelkov <kirr@mns.spb.ru> Date: Mon, 3 Feb 2014 13:08:49 +0400 Subject: [PATCH] tests: add checking that combine-diff emits only correct paths
where "correct paths" stands for paths that are different to all parents.
Up until now, we were testing combined diff only on one file, or on several files which were all different (t4038-diff-combined.sh).
As recent thinko in "simplify intersect_paths() further" showed, and also, since we are going to rework code for finding paths different to all parents, lets write at least basic tests.
Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru> --- t/t4057-diff-combined-paths.sh | 106 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 106 insertions(+) create mode 100755 t/t4057-diff-combined-paths.sh
diff --git a/t/t4057-diff-combined-paths.sh b/t/t4057-diff-combined-paths.sh new file mode 100755 index 0000000..097e632 --- /dev/null +++ b/t/t4057-diff-combined-paths.sh @@ -0,0 +1,106 @@ +#!/bin/sh + +test_description='combined diff show only paths that are different to all parents' + +. ./test-lib.sh + +# verify that diffc.expect matches output of +# `git diff -c --name-only HEAD HEAD^ HEAD^2` +diffc_verify () { + git diff -c --name-only HEAD HEAD^ HEAD^2 >diffc.actual && + test_cmp diffc.expect diffc.actual +} + +test_expect_success 'trivial merge - combine-diff empty' ' + for i in $(test_seq 1 9) + do + echo $i >$i.txt && + git add $i.txt + done && + git commit -m "init" && + git checkout -b side && + for i in $(test_seq 2 9) + do + echo $i/2 >>$i.txt + done && + git commit -a -m "side 2-9" && + git checkout master && + echo 1/2 >1.txt && + git commit -a -m "master 1" && + git merge side && + >diffc.expect && + diffc_verify +' + + +test_expect_success 'only one trully conflicting path' ' + git checkout side && + for i in $(test_seq 2 9) + do + echo $i/3 >>$i.txt + done && + echo "4side" >>4.txt && + git commit -a -m "side 2-9 +4" && + git checkout master && + for i in $(test_seq 1 9) + do + echo $i/3 >>$i.txt + done && + echo "4master" >>4.txt && + git commit -a -m "master 1-9 +4" && + test_must_fail git merge side && + cat <<-\EOF >4.txt && + 4 + 4/2 + 4/3 + 4master + 4side + EOF + git add 4.txt && + git commit -m "merge side (2)" && + echo 4.txt >diffc.expect && + diffc_verify +' + +test_expect_success 'merge introduces new file' ' + git checkout side && + for i in $(test_seq 5 9) + do + echo $i/4 >>$i.txt + done && + git commit -a -m "side 5-9" && + git checkout master && + for i in $(test_seq 1 3) + do + echo $i/4 >>$i.txt + done && + git commit -a -m "master 1-3 +4hello" && + git merge side && + echo "Hello World" >4hello.txt && + git add 4hello.txt && + git commit --amend && + echo 4hello.txt >diffc.expect && + diffc_verify +' + +test_expect_success 'merge removed a file' ' + git checkout side && + for i in $(test_seq 5 9) + do + echo $i/5 >>$i.txt + done && + git commit -a -m "side 5-9" && + git checkout master && + for i in $(test_seq 1 3) + do + echo $i/4 >>$i.txt + done && + git commit -a -m "master 1-3" && + git merge side && + git rm 4.txt && + git commit --amend && + echo 4.txt >diffc.expect && + diffc_verify +' + +test_done
-- 1.9.rc1.181.g641f458