git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Fix issues found by gcc 4.6.0

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 22, 2011, 12:49 UTC
Message-ID
<cover.1300798069.git.johannes.schindelin@gmx.de>

In general, our sources are quite clean. However, a few variables were unused. Previous gcc version did not find them because they were assigned values, but those values were never used nontheless.

The tricky question is whether 2/2 really fixes an issue or not. Unfortunately, my time is too limited to go into detail, but I figured it'd be better to raise the issue than to remain silent.

Johannes Schindelin (2):
  Remove unused variables
  Actually use retval
 builtin/fsck.c       |    3 +--
 builtin/remote-ext.c |    4 ----
 diff.c               |    3 +--
 merge-recursive.c    |    4 ----
 reachable.c          |    5 -----
 test-subprocess.c    |    3 +--
 transport-helper.c   |    3 +--
 tree-diff.c          |    2 +-
 8 files changed, 5 insertions(+), 22 deletions(-)
-- 
1.7.4.msysgit.0.167.ge91fd
Next: Johannes Schindelin
Message 1 of 11 in “Fix issues found by gcc 4.6.0”
  1. 0/2 Fix issues found by gcc 4.6.0Johannes Schindelin, Mar 22, 2011
  2. 1/2 Remove unused variablesJohannes Schindelin, Mar 22, 2011
  3. Junio C HamanoMar 22, 2011
  4. Johannes SchindelinMar 22, 2011
  5. Jonathan NiederMar 22, 2011
  6. 2/2 Actually use retvalJohannes Schindelin, Mar 22, 2011
  7. Junio C HamanoMar 22, 2011
  8. Johannes SchindelinMar 22, 2011
  9. 0/2 Re: [PATCH 2/2] Actually use retvalJonathan Nieder, Mar 23, 2011
  10. 1/2 tree-diff: make diff_tree return voidJonathan Nieder, Mar 23, 2011
  11. 2/2 tree-diff: make diff_tree_sha1 return voidJonathan Nieder, Mar 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.