git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Remove unused variables

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 22, 2011, 18:42 UTC
Message-ID
<alpine.DEB.1.00.1103221940050.1561@bonsai2>
In-Reply-To
<7v39mfkons.fsf@alter.siamese.dyndns.org>
Hi,
On Tue, 22 Mar 2011, Junio C Hamano wrote:
Show 13 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > Noticed by gcc 4.6.0.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> 
> Thanks.
> 
> I'll cherry pick only some bits, not because the changes in this patch 
> are wrong, but because I know some areas are in flux and I don't want to 
> deal with merge conflicts of the "one side fixed a small bug, the other 
> side majorly rewrote it and made the bug irrelevant" kind.

Understandable. I will have to deal with the merge conflicts, though, as I am stuck with 4.6.0 (and self-imposed -Werror, as you might remember) for the 64-bit Windows build. So I will keep the remains of the patch after rebasing in our 'devel' branch.

Ciao, Johannes

Previous: Junio C HamanoNext: Jonathan Nieder
Message 4 of 11 in “Fix issues found by gcc 4.6.0”
  1. 0/2 Fix issues found by gcc 4.6.0Johannes Schindelin, Mar 22, 2011
  2. 1/2 Remove unused variablesJohannes Schindelin, Mar 22, 2011
  3. Junio C HamanoMar 22, 2011
  4. Johannes SchindelinMar 22, 2011
  5. Jonathan NiederMar 22, 2011
  6. 2/2 Actually use retvalJohannes Schindelin, Mar 22, 2011
  7. Junio C HamanoMar 22, 2011
  8. Johannes SchindelinMar 22, 2011
  9. 0/2 Re: [PATCH 2/2] Actually use retvalJonathan Nieder, Mar 23, 2011
  10. 1/2 tree-diff: make diff_tree return voidJonathan Nieder, Mar 23, 2011
  11. 2/2 tree-diff: make diff_tree_sha1 return voidJonathan Nieder, Mar 23, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.