git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] Refactoring: remove duplicated code

From
Michael Lukashov <michael.lukashov@gmail.com>
Date
Feb 16, 2010, 23:42 UTC
Message-ID
<cover.1266360267.git.michael.lukashov@gmail.com>
Hi,

Here is 3rd iteration of my refactoring patches. These patches take into account suggestions made by Tay Ray Chuan, Johannes Sixt, Jeff King and Junio C Hamano

Michael Lukashov (4):
  Refactoring: remove duplicated code from builtin-send-pack.c and
    transport.c
  Refactoring: connect.c: move duplicated code to a new function
    'get_host_and_port'
  Refactoring: move duplicated code from builtin-pack-objects.c and
    fast-import.c to sha1_file.c
  Refactoring: move duplicated code from builtin-checkout.c and
    merge-recursive.c to xdiff-interface.c
 builtin-checkout.c     |   24 +-----
 builtin-fetch.c        |   20 +++---
 builtin-pack-objects.c |   31 +-------
 builtin-send-pack.c    |  191 ++----------------------------------------------
 cache.h                |    8 ++
 connect.c              |   83 +++++++--------------
 fast-import.c          |   29 +-------
 merge-recursive.c      |   23 +-----
 sha1_file.c            |   20 +++++
 transport.c            |   22 +++---
 transport.h            |   11 +++
 xdiff-interface.c      |   17 ++++
 xdiff-interface.h      |    1 +
 13 files changed, 123 insertions(+), 357 deletions(-)
Next: Michael Lukashov
Message 1 of 10 in “Refactoring: remove duplicated code”
  1. 0/4 Refactoring: remove duplicated codeMichael Lukashov, Feb 16, 2010
  2. 1/4 Refactoring: remove duplicated code from builtin-send-pack.c and transport.cMichael Lukashov, Feb 16, 2010
  3. Tay Ray ChuanFeb 17, 2010
  4. 2/4 Refactoring: connect.c: move duplicated code to a new function 'get_host_and_port'Michael Lukashov, Feb 16, 2010
  5. Larry D'AnnaFeb 17, 2010
  6. Michael LukashovFeb 17, 2010
  7. 2/4 Refactoring: connect.c: move duplicated code to a new function 'get_host_and_port'Michael Lukashov, Feb 17, 2010
  8. Junio C HamanoFeb 17, 2010
  9. 3/4 Refactoring: move duplicated code from builtin-pack-objects.c and fast-import.c to sha1_file.cMichael Lukashov, Feb 16, 2010
  10. 4/4 Refactoring: move duplicated code from builtin-checkout.c and merge-recursive.c to xdiff-interface.cMichael Lukashov, Feb 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.