git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/4] Refactoring: remove duplicated code from builtin-send-pack.c and transport.c

From
Tay Ray Chuan <rctay89@gmail.com>
Date
Feb 17, 2010, 02:23 UTC
Message-ID
<be6fef0d1002161823u48dc42f9g8b532e03763af17@mail.gmail.com>
In-Reply-To
<57f2a1b845f82f86709c71d1fbc530bb5fdb1a7f.1266360267.git.michael.lukashov@gmail.com>
Hi,

On Wed, Feb 17, 2010 at 7:42 AM, Michael Lukashov <michael.lukashov@gmail.com> wrote:

Show 5 quoted lines
> [snip]
> Also, move #define SUMMARY_WIDTH to transport.h and rename it TRANSPORT_SUMMARY_WIDTH
> as it is used in builtin-fetch.c and transport.c
>
> Signed-off-by: Michael Lukashov <michael.lukashov@gmail.com>
Apart from the long line in the patch message, looks ok to me.
Acked-by: Tay Ray Chuan <rctay89@gmail.com>
-- 
Cheers,
Ray Chuan
Previous: Michael LukashovNext: Michael Lukashov
Message 3 of 10 in “Refactoring: remove duplicated code”
  1. 0/4 Refactoring: remove duplicated codeMichael Lukashov, Feb 16, 2010
  2. 1/4 Refactoring: remove duplicated code from builtin-send-pack.c and transport.cMichael Lukashov, Feb 16, 2010
  3. Tay Ray ChuanFeb 17, 2010
  4. 2/4 Refactoring: connect.c: move duplicated code to a new function 'get_host_and_port'Michael Lukashov, Feb 16, 2010
  5. Larry D'AnnaFeb 17, 2010
  6. Michael LukashovFeb 17, 2010
  7. 2/4 Refactoring: connect.c: move duplicated code to a new function 'get_host_and_port'Michael Lukashov, Feb 17, 2010
  8. Junio C HamanoFeb 17, 2010
  9. 3/4 Refactoring: move duplicated code from builtin-pack-objects.c and fast-import.c to sha1_file.cMichael Lukashov, Feb 16, 2010
  10. 4/4 Refactoring: move duplicated code from builtin-checkout.c and merge-recursive.c to xdiff-interface.cMichael Lukashov, Feb 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.